Add tests and refactor#40
Draft
MichaelCurrin wants to merge 6 commits into
Draft
Conversation
Owner
Author
|
Maybe I can do this incrementally. Unfortunately I don't have tests for existing work so I'd have to rely on new tests being good. |
Owner
Author
|
This can be used as a jest guide too |
MichaelCurrin
commented
Dec 18, 2020
| const { License } = require('../components/license.js') | ||
|
|
||
| test('MIT license badge title displays correctly', () => { | ||
| var license = new License('MIT') |
Owner
Author
There was a problem hiding this comment.
Here I made License its own object.
This is actually not that important to me - I had the app working fine as is for license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a throwaway branch and PR but the idea was to write the ideal API using tests.
This does mean a long and slow refactor which is only usable when it is merged.
UPDATE: Some of the markdown and repo stuff might still be useful